In my previous post I pointed out all the things that needed to be looked at, here I will post the results of fixing these issues.
-------------------------------------------
MUST: rpmlint must be run on every package. The output should be posted in the review
[root@scotland SPECS]# rpmlint DXR-release.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
The spec file seems to be okay in terms of rpmlint.
[root@scotland SRPMS]# rpmlint DXR-release-1-1.1.src.rpm
DXR-release.src: W: summary-not-capitalized repository files
DXR-release.src: E: description-line-too-long repository contains open source and other distributable software for Fedora. This package contains
1 packages and 0 specfiles checked; 1 errors, 1 warnings.
ERROR
[root@scotland SPECS]# rpmlint -I description-line-too-long
description-line-too-long:
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.
Before: repository contains open source and other distributable software for Fedora. This package contains the repository GPG key as well as configuration for Yum.
After: repository contains open source and other distributable software for Fedora.
This package contains the repository GPG key as well as configuration for Yum.
WARNING
[root@scotland SRPMS]# rpmlint -I summary-not-capitalized
summary-not-capitalized:
Summary doesn't begin with a capital letter.
This is not a big issue, however I still changed it within the DXR-Release.spec
Before: Summary: repository files
After: Summary: Repository files
---------------------------------------
MUST: The License field in the package spec file must match the actual license.
In order to fix this I simply had to change the license from BSD to GPLv2 which is what it should be.
Before: License: BSD
After: License: GPLv2
---------------------------------------
To be continued
Sunday, February 14, 2010
Subscribe to:
Post Comments (Atom)
No comments:
Post a Comment